feat: added castlewars manual - #714
Open
ewby wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
huge thanks to @Indio3's guidance overall and work in #712, ended a lot of the learning curve headache with the book interfaces and components and made this task really simple.
historical accuracy is a bit "educated guess" with this one, but he and I decided to leave one page spread for each entry in the book. we couldn't find any screenshots or videos of the actual castlewars manual dating back to the end of 04 - beginning of 05 time period. we do however have a source for the text itself located below (thanks @thesuddensilent!):
https://discord.com/channels/953326730632904844/1126857544523063367/1533302966013132901
the 04-05 book interfaces combined with text + object models just doesn't seem possible to line up with whats in OSRS, and Indio confirmed with rsprox that OSRS is using an
indexed_bookinterface separate from the old book or inter_167 interfaces, most likely to achieve the layout below:https://oldschool.runescape.wiki/w/Castlewars_manual#Gallery
same layout attempted in 04: